lkml.org 
[lkml]   [2023]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm: huge_memory: Replace obsolete memalign() with posix_memalign()
From
On 13.04.23 03:17, Deming Wang wrote:
> memalign() is obsolete according to its manpage.
>
> Replace memalign() with posix_memalign()
>
> As a pointer is passed into posix_memalign(), initialize *one_page
> to NULL to silence a warning about the function's return value being
> used as uninitialized (which is not valid anyway because the error
> is properly checked before one_page is returned).

^ I'm getting tired of pointing out the same thing.

Please collect similar patches and send them as a series; and stop
copy-pasting the same thing into all of the similar patches you send.

Last but not least, tag you patches accordingly: "selftests/mm:
split_huge_page_test: ..."

>
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
> ---
> tools/testing/selftests/mm/split_huge_page_test.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c
> index cbb5e6893cbf..94c7dffc4d7d 100644
> --- a/tools/testing/selftests/mm/split_huge_page_test.c
> +++ b/tools/testing/selftests/mm/split_huge_page_test.c
> @@ -96,10 +96,10 @@ void split_pmd_thp(void)
> char *one_page;
> size_t len = 4 * pmd_pagesize;
> size_t i;
> + int ret;
>
> - one_page = memalign(pmd_pagesize, len);
> -
> - if (!one_page) {
> + ret = posix_memalign((void **)&one_page, pmd_pagesize, len);
> + if (ret < 0) {
> printf("Fail to allocate memory\n");
> exit(EXIT_FAILURE);
> }

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2023-04-13 19:06    [W:0.030 / U:1.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site