Messages in this thread | | | From | Yosry Ahmed <> | Date | Thu, 13 Apr 2023 04:26:45 -0700 | Subject | Re: [PATCH v6 2/3] mm: vmscan: move set_task_reclaim_state() near flush_reclaim_state() |
| |
On Thu, Apr 13, 2023 at 4:19 AM David Hildenbrand <david@redhat.com> wrote: > > On 13.04.23 12:40, Yosry Ahmed wrote: > > Move set_task_reclaim_state() near flush_reclaim_state() so that all > > helpers manipulating reclaim_state are in close proximity. > > > > Signed-off-by: Yosry Ahmed <yosryahmed@google.com> > > --- > > Hm, it's rather a simple helper to set the reclaim_state for a task, not > to modify it. > > No strong opinion, but I'd just leave it as it.
It's just personal taste to have helpers acting on the same data structure next to one another. I don't feel strongly about it either, I left it as a separate patch so that we can simply drop it. Peter also thought the same, so maybe I should just drop it.
> > -- > Thanks, > > David / dhildenb >
| |