Messages in this thread | | | Date | Thu, 13 Apr 2023 11:58:04 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH v2] iommu/amd: Fix "Guest Virtual APIC Table Root Pointer" configuration in IRTE |
| |
On Wed, Apr 05, 2023 at 01:03:17PM +0000, Kishon Vijay Abraham I wrote: > commit b9c6ff94e43a ("iommu/amd: Re-factor guest virtual APIC > (de-)activation code") while refactoring guest virtual APIC > activation/de-activation code, stored information for activate/de-activate > in "struct amd_ir_data". It used 32-bit integer data type for storing the > "Guest Virtual APIC Table Root Pointer" (ga_root_ptr), though the > "ga_root_ptr" is actually a 40-bit field in IRTE (Interrupt Remapping > Table Entry). > > This causes interrupts from PCIe devices to not reach the guest in the case > of PCIe passthrough with SME (Secure Memory Encryption) enabled as _SME_ > bit in the "ga_root_ptr" is lost before writing it to the IRTE. > > Fix it by using 64-bit data type for storing the "ga_root_ptr". While at > that also change the data type of "ga_tag" to u32 in order to match > the IOMMU spec. > > Fixes: b9c6ff94e43a ("iommu/amd: Re-factor guest virtual APIC (de-)activation code") > Cc: stable@vger.kernel.org # v5.4+ > Reported-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com> > Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> > Signed-off-by: Kishon Vijay Abraham I <kvijayab@amd.com>
Applied, thanks.
| |