Messages in this thread | | | Date | Thu, 13 Apr 2023 23:36:59 +0300 | Subject | Re: [PATCH v4 3/4] mfd: tps6586x: use devm-based power off handler | From | Dmitry Osipenko <> |
| |
On 4/13/23 10:46, Benjamin Bara wrote: > +static int tps6586x_power_off_handler(struct sys_off_data *data) > { > - if (tps6586x_clr_bits(tps6586x_dev, TPS6586X_SUPPLYENE, EXITSLREQ_BIT)) > - return; > + struct device *tps6586x_dev = data->cb_data; > + int ret; > + > + ret = tps6586x_clr_bits(tps6586x_dev, TPS6586X_SUPPLYENE, EXITSLREQ_BIT); > + if (ret) > + return ret; > > - tps6586x_set_bits(tps6586x_dev, TPS6586X_SUPPLYENE, SLEEP_MODE_BIT); > + return tps6586x_set_bits(tps6586x_dev, TPS6586X_SUPPLYENE, SLEEP_MODE_BIT);
Handlers must return NOTIFY_DONE or notifier_from_errno(). Sorry for missing this previously.
-- Best regards, Dmitry
| |