lkml.org 
[lkml]   [2023]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] crypto: ixp4xx - Do not check word size when compile testing
On Sun, Apr 9, 2023 at 9:47 AM Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Fri, Apr 07, 2023 at 02:37:44PM -0500, Tom Zanussi wrote:
> > COMPILE_TEST was added during the move to drivers/crypto/intel/ but
> > shouldn't have been as it triggers a build bug when not compiled by
> > the target compiler. So remove it to match the original.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Link: https://lore.kernel.org/oe-kbuild-all/202304061846.G6cpPXiQ-lkp@intel.com/
> > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> > ---
> > drivers/crypto/intel/ixp4xx/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> We could also fix it by making the BUILD_BUG_ON conditional:
>
> ---8<---
> The BUILD_BUG_ON preventing compilation on foreign architectures
> should be disabled when we're doing compile testing.
>
> Fixes: 1bc7fdbf2677 ("crypto: ixp4xx - Move driver to...")
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304061846.G6cpPXiQ-lkp@intel.com/
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

This fix is more elegant I think, as it keeps the compile coverage.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2023-04-13 22:12    [W:0.026 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site