Messages in this thread | | | From | Peng Fan <> | Subject | RE: [PATCH 2/2] input: imx_sc_key: add wakeup support | Date | Wed, 12 Apr 2023 15:58:40 +0000 |
| |
+Ulf
> Subject: RE: [PATCH 2/2] input: imx_sc_key: add wakeup support > > > Subject: Re: [PATCH 2/2] input: imx_sc_key: add wakeup support > > > > On Thu, Mar 23, 2023 at 05:31:41PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > Add support for waking up from system wide suspend. > > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > drivers/input/keyboard/imx_sc_key.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/input/keyboard/imx_sc_key.c > > b/drivers/input/keyboard/imx_sc_key.c > > > index d18839f1f4f6..234f23cf9990 100644 > > > --- a/drivers/input/keyboard/imx_sc_key.c > > > +++ b/drivers/input/keyboard/imx_sc_key.c > > > @@ -151,6 +151,8 @@ static int imx_sc_key_probe(struct > > platform_device *pdev) > > > priv->input = input; > > > platform_set_drvdata(pdev, priv); > > > > > > + device_init_wakeup(&pdev->dev, > > device_property_read_bool(&pdev->dev, "wakeup-source")); > > > + > > > > I wonder - could we move this to the device core? > > I see lots device drivers parse wakeup-source, so I also follow That. Not sure > whether could move this feature to device core, but anyway I could give a > try.
Do you think it is feasible to move device_init_wakeup into device core part?
Thanks, Peng. > > Thanks, > Peng. > > > > > error = imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE, > > SC_IRQ_BUTTON, > > > true); > > > if (error) { > > > -- > > > 2.37.1 > > > > > > > Thanks. > > > > -- > > Dmitry
| |