Messages in this thread | | | Date | Wed, 12 Apr 2023 08:27:14 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v6 0/5] hwmon: (pmbus/acbel-fsg032) Add Acbel power supply |
| |
On Wed, Apr 12, 2023 at 12:23:00AM -0500, Lakshmi Yadlapati wrote: > Adding new acbel,fsg032 driver and documentation updates. > > Changes since V5: > Add symlink from manufacturer serial number to ccin since ccin is not > available in acbel-fsg032 power supply driver.
Sorry, I fail to understand this change, and I am not inclined to accept it. There is no "as required by hwmon".
Guenter
> > Lakshmi Yadlapati (5): > dt-bindings: vendor-prefixes: Add prefix for acbel > dt-bindings: trivial-devices: Add acbel,fsg032 > hwmon: (pmbus/acbel-fsg032) Add Acbel power supply > docs: hwmon: Add documentaion for acbel-fsg032 PSU > ARM: dts: aspeed: p10bmc: Change power supply info > > .../devicetree/bindings/trivial-devices.yaml | 2 + > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > Documentation/hwmon/acbel-fsg032.rst | 80 ++++++++++++++++ > Documentation/hwmon/index.rst | 1 + > arch/arm/boot/dts/aspeed-bmc-ibm-bonnell.dts | 12 +-- > drivers/hwmon/pmbus/Kconfig | 9 ++ > drivers/hwmon/pmbus/Makefile | 1 + > drivers/hwmon/pmbus/acbel-fsg032.c | 95 +++++++++++++++++++ > 8 files changed, 196 insertions(+), 6 deletions(-) > create mode 100644 Documentation/hwmon/acbel-fsg032.rst > create mode 100644 drivers/hwmon/pmbus/acbel-fsg032.c > > -- > 2.37.2 >
| |