| Date | Wed, 12 Apr 2023 14:59:24 +0200 | Subject | Re: [PATCH 02/27] dt-bindings: phy: mediatek,dsi-phy: Add compatible for MT6795 Helio X10 | From | Alexandre Mergnat <> |
| |
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for MediaTek Helio X10 MT6795: this SoC uses > the same DSI PHY as MT8173. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml > index 26f2b887cfc1..a9f78344efdb 100644 > --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml > @@ -24,6 +24,10 @@ properties: > - enum: > - mediatek,mt7623-mipi-tx > - const: mediatek,mt2701-mipi-tx > + - items: > + - enum: > + - mediatek,mt6795-mipi-tx > + - const: mediatek,mt8173-mipi-tx
AFAIK, it should be: - items: - const: mediatek,mt6795-mipi-tx - const: mediatek,mt8173-mipi-tx
Since it isn't respected above for mt7623, it may be tolerated. Please, take this comment as a suggestion, isn't a NAK from me.
> - items: > - enum: > - mediatek,mt8365-mipi-tx
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
-- Regards, Alexandre
|