Messages in this thread | | | Date | Wed, 12 Apr 2023 13:10:33 +0200 | Subject | Re: [PATCH v7 3/6] Documentation: Add ABI doc for attributes of LJCA device | From | Oliver Neukum <> |
| |
On 10.04.23 12:44, Ye, Xiang wrote:
Hi,
>> do we really want each driver to have its own attribute for that? >> It seems to me that that should be unified. > Three ABI entries are added in this patch: ljca_version, ljca_trace_level, > and ljca_enable_dfu. The first two items are specified for LJCA device and > I think they can be kept in sysfs-bus-usb-devices-ljca. > > But for ljca_enable_dfu, I didn't see a unified DFU entry in sys-bus-usb. > I am not sure whether other USB devices have similar DFU mode or not. > > Any suggestions?
What exactly does this attribute do? Is it in addition to the normal DFU_DETACH + reset sequence, is it needed for DFU_DETACH to work, does it enable the DFU class interface descriptor?
A point of DFU is rather that the capability should be announced via descriptors. The answer would depend on what exactly this attribute does.
Regards Oliver
| |