Messages in this thread | | | Subject | Re: [PATCH v1 3/4] LoongArch: Use larch_insn_gen_break() for kprobes | From | Xi Ruoyao <> | Date | Wed, 12 Apr 2023 19:08:21 +0800 |
| |
On Wed, 2023-04-12 at 18:05 +0800, Tiezhu Yang wrote: > -static inline bool insns_not_supported(union loongarch_instruction insn) > +static inline bool insns_not_supported(u32 code) > { > + union loongarch_instruction insn; > + > + insn.word = code; > +
I remember Xuerui disliked this change. Maybe we can add __attribute__ (__transparent_union__) [1] for union loongarch_instruction instead?
[1]: https://gcc.gnu.org/onlinedocs/gcc/Common-Type-Attributes.html#index-transparent_005funion-type-attribute
-- Xi Ruoyao <xry111@xry111.site> School of Aerospace Science and Technology, Xidian University
| |