Messages in this thread | | | Subject | RE:(2) [PATCH 1/2] blk-integrity: add rq_integrity_payload_size helper | From | Jinyoung CHOI <> | Date | Wed, 12 Apr 2023 17:55:58 +0900 |
| |
>>> + >>> +static inline unsigned int rq_integrity_payload_size(struct request >>> *rq) >>> +{ >>> + if (WARN_ON_ONCE(queue_max_integrity_segments(rq->q) > 1)) >>> + return 0; >>> + return rq->bio->bi_integrity->bip_iter.bi_size; >>> +} >>> #else /* CONFIG_BLK_DEV_INTEGRITY */ >>> static inline int blk_rq_count_integrity_sg(struct request_queue *q, >>> struct bio *b) >> >> from the comments that I got in the past, you should only be adding >> a helper in the patch that is actually using it. >> >> -ck >> >> > > disregard my comment, I think this is correct looking at the next patch... > > -ck
OK Thanks for your review :) I sent it to the wrong email address. (result from get_maintainer.pl) I will update your email address for cc.
Kind Regards, Jinyoung.
| |