Messages in this thread | | | Date | Wed, 12 Apr 2023 10:43:52 +0200 | Subject | Re: [PATCH] mm/rmap: convert __page_{set, check}_anon_rmap() to folios | From | David Hildenbrand <> |
| |
On 12.04.23 04:18, Yajun Deng wrote: > The 2nd parameter in __page_set_anon_rmap() is only used by > SetPageAnonExclusive(), so there is no need to put > SetPageAnonExclusive() in __page_set_anon_rmap(). > > Remove SetPageAnonExclusive() from __page_set_anon_rmap() and modify > __page_set_anon_rmap() to __folio_set_anon_rmap(). > > Since __page_check_anon_rmap() needs a folio, we can directly use > and change it to __folio_check_anon_rmap(). >
Leaking the SetPageAnonExclusive() into all callers is not an improvement.
Not convinced we want this patch TBH. Tentative NAK.
-- Thanks,
David / dhildenb
| |