Messages in this thread | | | Date | Wed, 12 Apr 2023 10:26:46 +0200 | Subject | Re: [PATCH v4 1/7] dt-bindings: phy: Add StarFive JH7110 USB document | From | Krzysztof Kozlowski <> |
| |
On 06/04/2023 03:52, Minda Chen wrote: > Add StarFive JH7110 SoC USB 2.0 PHY dt-binding.
Not much improvements in the subject. I asked to drop, not replace document with document.
"Add StarFive JH7110 USB PHY"
> > Signed-off-by: Minda Chen <minda.chen@starfivetech.com> > --- > .../bindings/phy/starfive,jh7110-usb-phy.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml b/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml > new file mode 100644 > index 000000000000..80604dfe01f0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/starfive,jh7110-usb-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive USB 2.0 PHY
Missing model name.
> + > +maintainers: > + - Minda Chen <minda.chen@starfivetech.com> > +
Best regards, Krzysztof
| |