Messages in this thread | | | Date | Wed, 12 Apr 2023 20:44:14 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enabling/disabling |
| |
On Mon, 10 Apr 2023 15:48:56 +0300 Radu Pirea (OSS) wrote: > - if (phydev->interrupts == PHY_INTERRUPT_ENABLED) > + if (phydev->interrupts == PHY_INTERRUPT_ENABLED) { > + phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, PTP_IRQS, PTP_IRQS);
Isn't the third argument supposed to be the address? Am I missing something or this patch was no tested properly?
Also why ignore the return value?
> return phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, > VEND1_PHY_IRQ_EN, PHY_IRQ_LINK_EVENT); > - else > + } else { > + phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, PTP_IRQS, PTP_IRQS); > return phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, > VEND1_PHY_IRQ_EN, PHY_IRQ_LINK_EVENT); > + }
| |