Messages in this thread | | | Date | Wed, 12 Apr 2023 09:37:35 +0200 | From | Neil Armstrong <> | Subject | Re: [PATCH v1 2/5] mtd: rawnand: meson: replace GENMASK() macro with define |
| |
Hi,
On 12/04/2023 08:16, Arseniy Krasnov wrote:
Please add a commit message
> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru> > --- > drivers/mtd/nand/raw/meson_nand.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index 256c37c76526..45b53d420aed 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -110,6 +110,8 @@ > > #define PER_INFO_BYTE 8 > > +#define NFC_CMD_RAW_LEN (GENMASK(13, 0))
Drop the () around GENMASK(13, 0)
> + > struct meson_nfc_nand_chip { > struct list_head node; > struct nand_chip nand; > @@ -300,7 +302,7 @@ static void meson_nfc_cmd_access(struct nand_chip *nand, int raw, bool dir, > > if (raw) { > len = mtd->writesize + mtd->oobsize; > - cmd = (len & GENMASK(13, 0)) | scrambler | DMA_DIR(dir); > + cmd = (len & NFC_CMD_RAW_LEN) | scrambler | DMA_DIR(dir); > writel(cmd, nfc->reg_base + NFC_REG_CMD); > return; > } > @@ -550,7 +552,7 @@ static int meson_nfc_read_buf(struct nand_chip *nand, u8 *buf, int len) > if (ret) > goto out; > > - cmd = NFC_CMD_N2M | (len & GENMASK(13, 0)); > + cmd = NFC_CMD_N2M | (len & NFC_CMD_RAW_LEN); > writel(cmd, nfc->reg_base + NFC_REG_CMD); > > meson_nfc_drain_cmd(nfc); > @@ -574,7 +576,7 @@ static int meson_nfc_write_buf(struct nand_chip *nand, u8 *buf, int len) > if (ret) > return ret; > > - cmd = NFC_CMD_M2N | (len & GENMASK(13, 0)); > + cmd = NFC_CMD_M2N | (len & NFC_CMD_RAW_LEN); > writel(cmd, nfc->reg_base + NFC_REG_CMD); > > meson_nfc_drain_cmd(nfc);
Thanks, Neil
| |