Messages in this thread | | | Date | Wed, 12 Apr 2023 14:19:29 -0700 | Subject | Re: [PATCH net-next 6/8] net: mscc: ocelot: strengthen type of "u32 reg" and "u32 base" in ocelot_stats.c | From | Jacob Keller <> |
| |
On 4/12/2023 5:47 AM, Vladimir Oltean wrote: > Use the specific enum ocelot_reg to make it clear that the region > registers are encoded and not plain addresses. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- > drivers/net/ethernet/mscc/ocelot_stats.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/mscc/ocelot_stats.c b/drivers/net/ethernet/mscc/ocelot_stats.c > index 99a14a942600..a381e326cb2b 100644 > --- a/drivers/net/ethernet/mscc/ocelot_stats.c > +++ b/drivers/net/ethernet/mscc/ocelot_stats.c > @@ -145,7 +145,7 @@ enum ocelot_stat { > }; > > struct ocelot_stat_layout { > - u32 reg; > + enum ocelot_reg reg; > char name[ETH_GSTRING_LEN]; > }; > > @@ -257,7 +257,7 @@ struct ocelot_stat_layout { > > struct ocelot_stats_region { > struct list_head node; > - u32 base; > + enum ocelot_reg base; > enum ocelot_stat first_stat; > int count; > u32 *buf; > @@ -889,7 +889,7 @@ static int ocelot_prepare_stats_regions(struct ocelot *ocelot) > { > struct ocelot_stats_region *region = NULL; > const struct ocelot_stat_layout *layout; > - unsigned int last = 0; > + enum ocelot_reg last = 0; > int i; > > INIT_LIST_HEAD(&ocelot->stats_regions);
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
| |