Messages in this thread | | | From | Jesper Dangaard Brouer <> | Date | Wed, 12 Apr 2023 21:41:53 +0200 | Subject | Re: [PATCH bpf V9 1/6] selftests/bpf: xdp_hw_metadata remove bpf_printk and add counters |
| |
On 12/04/2023 20.56, Stanislav Fomichev wrote: > On Wed, Apr 12, 2023 at 11:35 AM Jesper Dangaard Brouer > <brouer@redhat.com> wrote: >> The tool xdp_hw_metadata can be used by driver developers >> implementing XDP-hints metadata kfuncs. >> >> Remove all bpf_printk calls, as the tool already transfers all the >> XDP-hints related information via metadata area to AF_XDP >> userspace process. >> >> Add counters for providing remaining information about failure and >> skipped packet events. >> >> Signed-off-by: Jesper Dangaard Brouer<brouer@redhat.com> > Acked-by: Stanislav Fomichev<sdf@google.com> > > nit: maybe those ++ should be __sync_add_and_fetch instead? Then you > should be able to drop volatile..
That is a good suggestion. I will update the patch and add your ACK.
--Jesper
| |