Messages in this thread | | | Subject | RE:(2) [PATCH 2/2] nvme-pci: fix metadata mapping length | From | Jinyoung CHOI <> | Date | Wed, 12 Apr 2023 16:12:30 +0900 |
| |
>> Even if the memory allocated for integrity is physically continuous, >> struct bio_vec is composed separately for each page size. >> In order not to use the blk_rq_map_integrity_sg(), the length of the >> DMA mapping should be the total size of integrity payload. > > Hmm, looking outside the bio_vec is pretty nasty. > > I think the problem here is that bio_integrity_add_page should > just add to the existing bvec, similar to bio_add_page and friends.
I agree with you. I think the problem is bio_integrity_add_page(). If it is modified, sg functions for blk-integrity should also be modified.
If you think the blk-integrity modification is better, I will send an mail to block mailing after modifying it.
Best Regards. Jinyoung.
| |