lkml.org 
[lkml]   [2023]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net] net: bridge: switchdev: don't notify FDB entries with "master dynamic"
On Wed, Apr 12, 2023 at 07:24:07PM +0300, Vladimir Oltean wrote:
> I'll send v2 with BR_FDB_ADDED_BY_EXT_LEARN not prevented from being
> notified from switchdev.
>
> Unless you have any objection, I won't send v2 like this:
>
> if (test_bit(BR_FDB_ADDED_BY_USER, &fdb->flags) &&
> !test_bit(BR_FDB_STATIC, &fdb->flags) &&
> !test_bit(BR_FDB_ADDED_BY_EXT_LEARN, &fdb->flags))
> return;
>
> but like this:
>
> /* Entries with just the BR_FDB_ADDED_BY_USER flag set were created
> * using 'bridge fdb add ... master dynamic'
> */
> if (fdb->flags == BIT(BR_FDB_ADDED_BY_USER))
> return;

LGTM. Please copy me on v2 and I will run it through regression. Will
try to report results before tomorrow's PR.

Thanks!

\
 
 \ /
  Last update: 2023-04-12 18:51    [W:0.046 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site