Messages in this thread | | | Date | Wed, 12 Apr 2023 17:12:58 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] spi: spi-qcom-qspi: Add DMA mode support |
| |
On Wed, Apr 12, 2023 at 08:59:06PM +0530, Vijaya Krishna Nivarthi wrote: > On 4/6/2023 8:58 PM, Mark Brown wrote:
> > > > > + if (ctrl->xfer.dir == QSPI_READ) > > > > > + byte_ptr = (uint8_t *)xfer->rx_buf; > > > > > + else > > > > > + byte_ptr = (uint8_t *)xfer->tx_buf; > > > > If we need to cast to or from void * there's some sort of problem. > > > the tx_buf is a const void* > > > in v2 I will cast for tx_buf only?
> > Or just keep byte_ptr as const - we're not modifying it are we?
> We are modifying it, hence did cast for tx_buf only
If it's being modified won't that upset the callers that thought it was const and didn't expect the data to change? [unhandled content-type:application/pgp-signature] | |