lkml.org 
[lkml]   [2023]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2] qlcnic: check pci_reset_function result
On Tue, Apr 11, 2023 at 01:24:33PM +0200, Paolo Abeni wrote:
> On Fri, 2023-04-07 at 10:18 +0300, Denis Plotnikov wrote:
> > Static code analyzer complains to unchecked return value.
> > The result of pci_reset_function() is unchecked.
> > Despite, the issue is on the FLR supported code path and in that
> > case reset can be done with pcie_flr(), the patch uses less invasive
> > approach by adding the result check of pci_reset_function().
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Fixes: 7e2cf4feba05 ("qlcnic: change driver hardware interface mechanism")
> > Signed-off-by: Denis Plotnikov <den-plotnikov@yandex-team.ru>
>
> Any special reason to target the net-next tree? This looks like a -net
> candidate to me?

FWIIW, net would be fine by me.
Sorry for not noticing this during earlier review.

\
 
 \ /
  Last update: 2023-04-11 13:32    [W:0.599 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site