Messages in this thread | | | From | "Neeli, Srinivas" <> | Subject | RE: [PATCH V3 2/4] dt-bindings: watchdog: xlnx,versal-wwdt: Add versal watchdog bindings | Date | Tue, 11 Apr 2023 10:46:58 +0000 |
| |
Hi Krzysztof,
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, April 4, 2023 12:03 AM > To: Neeli, Srinivas <srinivas.neeli@amd.com>; Datta, Shubhrajyoti > <shubhrajyoti.datta@amd.com>; Simek, Michal <michal.simek@amd.com>; > Goud, Srinivas <srinivas.goud@amd.com>; wim@linux-watchdog.org; > linux@roeck-us.net; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org > Cc: linux-watchdog@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; git (AMD- > Xilinx) <git@amd.com>; git@xilinx.com; neelisrinivas18@gmail.com > Subject: Re: [PATCH V3 2/4] dt-bindings: watchdog: xlnx,versal-wwdt: Add > versal watchdog bindings > > On 31/03/2023 09:41, Srinivas Neeli wrote: > > Versal watchdog driver uses window watchdog mode. Window watchdog > > Subject: drop second/last, redundant "bindings". The "dt-bindings" > prefix is already stating that these are bindings. > > > timer(WWDT) contains closed(first) and open(second) window with > > 32 bit width. Write to the watchdog timer within predefined window > > periods of time. This means a period that is not too soon and a period > > that is not too late. > > > > This patch adds devicetree bindings for versal window watchdog device. > > Do not use "This commit/patch", but imperative mood. See: > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/sub > mitting-patches.rst#L95 >
Thanks for review, I will address all changes in next version.
> > > > Signed-off-by: Srinivas Neeli <srinivas.neeli@amd.com> > > --- > > Changes in V3: > > - Removed xlnx,close_percent property. > > Changes in V2: > > - Added watchdog ref > > - Removed timeout-sec property > > - Used 4 spaces for example indentation. > > --- > > .../bindings/watchdog/xlnx,versal-wwdt.yaml | 50 +++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > > b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > > new file mode 100644 > > index 000000000000..dea1e7c487d3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/watchdog/xlnx,versal- > wwdt.yaml > > @@ -0,0 +1,50 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/watchdog/xlnx,versal-wwdt.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Xilinx Versal window watchdog timer controller > > + > > +maintainers: > > + - Neeli Srinivas <srinivas.neeli@amd.com> > > + > > +description: > > + Versal watchdog driver uses window watchdog mode. Window watchdog > > What is driver? If you mean Linux driver, then drop all references to it and > rephrase to describe hardware. > > > + timer(WWDT) contains closed(first) and open(second) window with > > + 32 bit width. Write to the watchdog timer within predefined window > > + periods of time. This means a period that is not too soon and a > > + period that is not too late. The WWDT has to be restarted within > > + the open window time. If software tries to restart WWDT outside of > > + the open window time period, it generates a reset. > > + > > +allOf: > > + - $ref: /schemas/watchdog/watchdog.yaml# > > All other examples reference local watchdog.yaml. Don't do it differently > than others (git grep watchdog.yaml) > > > + > > Best regards, > Krzysztof
| |