Messages in this thread | | | Date | Tue, 11 Apr 2023 15:21:31 -0700 | Subject | Re: [PATCH] Documentation: firmware: Clarify firmware path usage | From | Florian Fainelli <> |
| |
On 4/11/23 15:20, Jonathan Corbet wrote: > Greg KH <gregkh@linuxfoundation.org> writes: > >> On Mon, Apr 10, 2023 at 04:12:32PM -0700, Florian Fainelli wrote: >>> I was not sure whether it was on purpose or not, Greg, will we break >>> anyone's use case if we strip off \n from the firmware path passed via >>> sysfs? >> >> I do not know, sorry. > > I would be amazed if anybody is putting newlines into their firmware > path; that would be kind of a silly thing to do. > > That said, I've been amazed before. > > I'll go ahead and apply the docs patch, but it still doesn't really seem > like the right fix to me.
I will submit a patch that strips off newlines from sysfs provided firmware paths and if this turns out to break someone's use case it could still be reverted, sounds good? -- Florian
| |