lkml.org 
[lkml]   [2023]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 5/7] soc: starfive: Use call back to parse device tree resources
    On Mon, Apr 10, 2023 at 11:47:41PM -0700, Changhuang Liang wrote:
    > Different compatible parse device tree resources work in different ways.

    Right now there is only one compatible, so this commit message needs to
    be expanded on to provide more information on your motivation.

    > Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>

    > static int jh71xx_pmu_init_domain(struct jh71xx_pmu *pmu, int index)
    > {
    > struct jh71xx_pmu_dev *pmd;
    > @@ -296,23 +325,20 @@ static int jh71xx_pmu_probe(struct platform_device *pdev)
    > if (!pmu)
    > return -ENOMEM;
    >
    > - pmu->base = device_node_to_regmap(np);
    > - if (IS_ERR(pmu->base))
    > - return PTR_ERR(pmu->base);
    > -
    > - pmu->irq = platform_get_irq(pdev, 0);
    > - if (pmu->irq < 0)
    > - return pmu->irq;
    > -
    > - ret = devm_request_irq(dev, pmu->irq, jh71xx_pmu_interrupt,
    > - 0, pdev->name, pmu);
    > - if (ret)
    > - dev_err(dev, "failed to request irq\n");
    > + spin_lock_init(&pmu->lock);
    >
    > match_data = of_device_get_match_data(dev);
    > if (!match_data)
    > return -EINVAL;
    >
    > + if (match_data->pmu_parse_dt) {

    How can this be false?

    Cheers,
    Conor.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2023-04-11 23:07    [W:7.534 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site