Messages in this thread | | | Date | Tue, 11 Apr 2023 10:25:21 -0700 | Subject | Re: [PATCH v2 1/2] dt-bindings: firmware: arm,scmi: support parameter passing in smc/hvc | From | Nikunj Kela <> |
| |
On 4/11/2023 10:18 AM, Krzysztof Kozlowski wrote: > On 10/04/2023 20:20, Nikunj Kela wrote: >> Currently, smc/hvc calls are made with smc-id only. The parameters are >> all set to zeros. This patch defines two optional device tree bindings, >> that can be used to pass parameters in smc/hvc calls. >> >> This is useful when multiple scmi instances are used with common smc-id. >> >> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> > Since you sent v2 before our discussion finished, let me answer here: > this does not look like property for DT. Do not send new patches without > giving reviewers chance to respond. Ok. My rationale on that is, if we allow smc-id which goes in r0/w0/x0 registers in smc/hvc call to be part of dtb, then we should allow parameters which go in r1/w1/x1 to r6/w6/x6 register to be part of dtb. If you have an alternative suggestion, I am all ears! > Best regards, > Krzysztof >
| |