lkml.org 
[lkml]   [2023]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: tsl2772: remove unused prox_diode_mask variable
On Mon, 27 Mar 2023 16:07:48 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Mon, Mar 27, 2023 at 08:08:23AM -0400, Tom Rix wrote:
> > clang with W=1 reports
> > drivers/iio/light/tsl2772.c:576:24: error: variable
> > 'prox_diode_mask' set but not used [-Werror,-Wunused-but-set-variable]
> > int i, ret, num_leds, prox_diode_mask;
> > ^
> > This variable is not used so remove it.
>
> While from the compilation point of view this is a correct fix, I think
> we need to hear from the author (or interested stakeholders) about this
> feature. Perhaps it should be enabled / fixed differently.
>

Superficially it looks like this value should have been stored to
chip->settings.prox_diode

+CC people who might know...

Jonathan

\
 
 \ /
  Last update: 2023-04-01 16:05    [W:0.805 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site