Messages in this thread | | | Date | Thu, 9 Mar 2023 17:14:41 +0530 | Subject | Re: [EXTERNAL] Re: [PATCH v5 1/2] dt-bindings: net: Add ICSSG Ethernet | From | Md Danish Anwar <> |
| |
Hi Krzysztof,
On 07/03/23 14:28, Krzysztof Kozlowski wrote: > On 07/03/2023 05:57, Md Danish Anwar wrote: >>>> +allOf: >>>> + - $ref: /schemas/remoteproc/ti,pru-consumer.yaml# >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - ti,am654-icssg-prueth # for AM65x SoC family >>>> + >>>> + ti,sram: >>>> + $ref: /schemas/types.yaml#/definitions/phandle >>>> + description: >>>> + phandle to MSMC SRAM node >>> >>> I believe we have a standard 'sram' property to point to SRAM nodes >>> assuming this is just mmio-sram or similar. >>> >> >> Yes, we have standard 'sram' property but Krzysztof had asked me to make the >> sram property vendor specific in last revision of this series. > > Sorry about that. I missed that we already have a 'sram'. The question > remains whether this is a phandle to MMIO SRAM or similar (sram.yaml). > > Best regards, > Krzysztof >
The SRAM that we are using here is phandle to MMIO-SRAM only. In the example section you can see, sram node points to msmc_ram (ti,sram = <&msmc_ram>;) And msmc_ram has compatible as "mmio-sram" in k3-am65-main.dtsi [1].
msmc_ram: sram@70000000 { compatible = "mmio-sram"; reg = <0x0 0x70000000 0x0 0x200000>;
So I can use 'sram' property as there is no need to make this as ti specific. Let me know if it seems good to you.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/ti/k3-am65-main.dtsi?h=v6.3-rc1#n11
-- Thanks and Regards, Danish.
| |