lkml.org 
[lkml]   [2023]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] watchdog: ixp4xx: Use devm_clk_get_enabled() helper
On Sat, Dec 31, 2022 at 12:07:27PM +0100, Christophe JAILLET wrote:
> The devm_clk_get_enabled() helper:
> - calls devm_clk_get()
> - calls clk_prepare_enable() and registers what is needed in order to
> call clk_disable_unprepare() when needed, as a managed resource.
>
> This simplifies the code and avoids the need of a dedicated function used
> with devm_add_action_or_reset().
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> Note that I get a compilation error because read_cpuid_id() is not defined
> on my system (x86_64).
> So I think that a "depends on ARM<something>" in missing in a KConfig file.
>
> Fixing it could help compilation farms build-bots.

As mentioned, this not how build dependencies work. The code builds fine
with arm:allmodconfig. It is not enabled with x86_64:allmodconfig since
it depends on ARCH_IXP4XX. It is is not expected to be buildable if
ARCH_IXP4XX is not selected.

Guenter

> ---
> drivers/watchdog/ixp4xx_wdt.c | 18 +++---------------
> 1 file changed, 3 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/watchdog/ixp4xx_wdt.c b/drivers/watchdog/ixp4xx_wdt.c
> index 281a48d9889f..607ce4b8df57 100644
> --- a/drivers/watchdog/ixp4xx_wdt.c
> +++ b/drivers/watchdog/ixp4xx_wdt.c
> @@ -112,12 +112,6 @@ static const struct watchdog_info ixp4xx_wdt_info = {
> .identity = KBUILD_MODNAME,
> };
>
> -/* Devres-handled clock disablement */
> -static void ixp4xx_clock_action(void *d)
> -{
> - clk_disable_unprepare(d);
> -}
> -
> static int ixp4xx_wdt_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -139,16 +133,10 @@ static int ixp4xx_wdt_probe(struct platform_device *pdev)
> * Retrieve rate from a fixed clock from the device tree if
> * the parent has that, else use the default clock rate.
> */
> - clk = devm_clk_get(dev->parent, NULL);
> - if (!IS_ERR(clk)) {
> - ret = clk_prepare_enable(clk);
> - if (ret)
> - return ret;
> - ret = devm_add_action_or_reset(dev, ixp4xx_clock_action, clk);
> - if (ret)
> - return ret;
> + clk = devm_clk_get_enabled(dev->parent, NULL);
> + if (!IS_ERR(clk))
> iwdt->rate = clk_get_rate(clk);
> - }
> +
> if (!iwdt->rate)
> iwdt->rate = IXP4XX_TIMER_FREQ;
>

\
 
 \ /
  Last update: 2023-03-27 00:47    [W:0.178 / U:1.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site