Messages in this thread | | | From | Gabriel Krisman Bertazi <> | Subject | Re: [PATCH 11/17] unicode: remove MODULE_LICENSE in non-modules | Date | Mon, 06 Mar 2023 10:32:53 -0500 |
| |
Nick Alcock <nick.alcock@oracle.com> writes:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Gabriel Krisman Bertazi <krisman@collabora.com> > Cc: linux-fsdevel@vger.kernel.org > ---
Acked-by: Gabriel Krisman Bertazi <krisman@suse.de>
Thanks,
-- Gabriel Krisman Bertazi
| |