Messages in this thread | | | From | Masahiro Yamada <> | Date | Mon, 6 Mar 2023 00:10:22 +0900 | Subject | Re: [PATCH v10 03/13] kbuild: add tristate checker |
| |
On Tue, Dec 6, 2022 at 1:32 AM Nick Alcock <nick.alcock@oracle.com> wrote: > > This new check target uses the tristate.conf machinery just added, and > modules.builtin.objs, to identify source files that have MODULE_* > declarations despite not being modules according to Kconfig. After > commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), all such declarations will cause > modprobe to misidentify their containing object file as a module when it > is not, which might cause it to spuriously fail when trying to load > something that is built in to the kernel.
Having false-positives in modules.builtin should be OK.
Also, scripts/check-tristates.mk is just a rename of scripts/Makefile.modbuiltin.
NACK.
-- Best Regards
Masahiro Yamada
| |