Messages in this thread | | | Subject | Re: [PATCH 4/5] wifi: rtw88: Remove redundant pci_clear_master | From | Kalle Valo <> | Date | Fri, 31 Mar 2023 14:49:14 +0000 (UTC) |
| |
Cai Huoqing <cai.huoqing@linux.dev> wrote:
> Remove pci_clear_master to simplify the code, > the bus-mastering is also cleared in do_pci_disable_device, > like this: > ./drivers/pci/pci.c:2197 > static void do_pci_disable_device(struct pci_dev *dev) > { > u16 pci_command; > > pci_read_config_word(dev, PCI_COMMAND, &pci_command); > if (pci_command & PCI_COMMAND_MASTER) { > pci_command &= ~PCI_COMMAND_MASTER; > pci_write_config_word(dev, PCI_COMMAND, pci_command); > } > > pcibios_disable_device(dev); > }. > And dev->is_busmaster is set to 0 in pci_disable_device. > > Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev> > Reviewed-by: Simon Horman <simon.horman@corigine.com> > Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
e665c6d67e54 wifi: rtw88: Remove redundant pci_clear_master
-- https://patchwork.kernel.org/project/linux-wireless/patch/20230323112613.7550-4-cai.huoqing@linux.dev/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |