Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 31 Mar 2023 14:44:31 +0200 | Subject | Re: [PATCH 2/7] driver core: create class_is_registered() |
| |
On Fri, Mar 31, 2023 at 11:33 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> Some classes (i.e. gpio), want to know if they have been registered or > not, and poke around in the class's internal structures to try to figure > this out. Because this is not really a good idea, provide a function > for classes to call to try to figure this out. > > Note, this is racy as the state of the class could change at any moment > in time after the call is made, but as usually a class only wants to > know if it has been registered yet or not, it should be fairly safe to > use, and is just as safe as the previous "poke at the class internals" > check was. > > Move the gpiolib code to use this function as proof that it works > properly. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Bartosz Golaszewski <brgl@bgdev.pl> > Cc: Sebastian Reichel <sre@kernel.org> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Cc: linux-gpio@vger.kernel.org > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This looks good to me! Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |