lkml.org 
[lkml]   [2023]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/8] erofs: simplify erofs_xattr_generic_get()
On Thu, 30 Mar 2023 16:29:05 +0800
Jingbo Xu <jefflexu@linux.alibaba.com> wrote:

> erofs_xattr_generic_get() won't be called from xattr handlers other than
> user/trusted/security xattr handler, and thus there's no need of extra
> checking.
>
> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Reviewed-by: Yue Hu <huyue2@coolpad.com>

> ---
> fs/erofs/xattr.c | 17 +++--------------
> 1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/fs/erofs/xattr.c b/fs/erofs/xattr.c
> index dc36a0c0919c..d76b74ece2e5 100644
> --- a/fs/erofs/xattr.c
> +++ b/fs/erofs/xattr.c
> @@ -432,20 +432,9 @@ static int erofs_xattr_generic_get(const struct xattr_handler *handler,
> struct dentry *unused, struct inode *inode,
> const char *name, void *buffer, size_t size)
> {
> - struct erofs_sb_info *const sbi = EROFS_I_SB(inode);
> -
> - switch (handler->flags) {
> - case EROFS_XATTR_INDEX_USER:
> - if (!test_opt(&sbi->opt, XATTR_USER))
> - return -EOPNOTSUPP;
> - break;
> - case EROFS_XATTR_INDEX_TRUSTED:
> - break;
> - case EROFS_XATTR_INDEX_SECURITY:
> - break;
> - default:
> - return -EINVAL;
> - }
> + if (handler->flags == EROFS_XATTR_INDEX_USER &&
> + !test_opt(&EROFS_I_SB(inode)->opt, XATTR_USER))
> + return -EOPNOTSUPP;
>
> return erofs_getxattr(inode, handler->flags, name, buffer, size);
> }

\
 
 \ /
  Last update: 2023-03-31 08:18    [W:0.193 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site