Messages in this thread | | | Date | Fri, 31 Mar 2023 18:05:50 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH v3] crypto - img-hash: Depend on OF and silence compile test warning |
| |
On Sun, Mar 26, 2023 at 10:50:27AM +0200, Krzysztof Kozlowski wrote: > The driver is specific to OF platforms (can match only via OF table), > thus add dependency on CONFIG_OF. Mark the of_device_id table as > unused. This also fixes W=1 warning: > > drivers/crypto/img-hash.c:930:34: error: ‘img_hash_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
...
> diff --git a/drivers/crypto/img-hash.c b/drivers/crypto/img-hash.c > index fe93d19e3044..2be364d9f592 100644 > --- a/drivers/crypto/img-hash.c > +++ b/drivers/crypto/img-hash.c > @@ -927,7 +927,7 @@ static void img_hash_done_task(unsigned long data) > img_hash_finish_req(hdev->req, err); > } > > -static const struct of_device_id img_hash_match[] = { > +static const struct of_device_id img_hash_match[] __maybe_unused = { > { .compatible = "img,hash-accelerator" }, > {} > };
I have applied this hunk as it renders the Kconfig change unnecessary.
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |