Messages in this thread | | | Date | Fri, 31 Mar 2023 11:47:19 +0200 | Subject | Re: [PATCH] dt-bindings: maxim,max98371: Convert to DT schema | From | Krzysztof Kozlowski <> |
| |
On 31/03/2023 04:05, André Morishita wrote: > Convert the Maxim Integrated MAX98371 audio codec bindings to DT schema. > > Signed-off-by: André Morishita <andremorishita@gmail.com> > ---
Thank you for your patch. There is something to discuss/improve.
> +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + max98371: max98371@31 {
Generic node names, so: codec
And drop label (max98371:)
> + compatible = "maxim,max98371"; > + reg = <0x31>;
#sound-dai-cells = <0>;
> + }; > + };
Best regards, Krzysztof
| |