Messages in this thread | | | Date | Fri, 31 Mar 2023 10:12:31 +0200 | Subject | Re: [PATCH v1 1/2] iopoll: Introduce ioreadXX_poll_timeout() macros | From | Olliver Schinagl <> |
| |
Hey Andy,
On 30-03-2023 16:14, Andy Shevchenko wrote: > From: Olliver Schinagl <oliver@schinagl.nl> > > There are users in the Linux kernel that would benefit from using > ioreadXX_poll_timeout() macros, such as ioread32_poll_timeout(). > Introduce those macros. > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> > Co-developed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > include/linux/iopoll.h | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/include/linux/iopoll.h b/include/linux/iopoll.h > index 2c8860e406bd..30ba609175a7 100644 > --- a/include/linux/iopoll.h > +++ b/include/linux/iopoll.h > @@ -140,6 +140,7 @@ > #define readx_poll_timeout_atomic(op, addr, val, cond, delay_us, timeout_us) \ > read_poll_timeout_atomic(op, val, cond, delay_us, timeout_us, false, addr) > > +/* readX() */ > #define readb_poll_timeout(addr, val, cond, delay_us, timeout_us) \ > readx_poll_timeout(readb, addr, val, cond, delay_us, timeout_us) > > <snip> > #endif /* _LINUX_IOPOLL_H */ Thanks for re-posting this? (I don't recall If I actually posted the first time around).
But I actually have a small addendum for this series, as it will break `drivers/net/wwan/t7xx/t7xx_dpmaif.c` due to a redefinition (yeah I know).
So I have: https://gitlab.com/olliver/linux/-/commit/c9e591f2dabb2dbaeceebee61fa70b70fdbffc2a https://gitlab.com/olliver/linux/-/commit/41e0f8c08a1c55940813a240215910336ad7bec2 https://gitlab.com/olliver/linux/-/commit/f36562f09b0185d403415864ef7218b46a742cdc https://gitlab.com/olliver/linux/-/commit/66237fd97bc42d272602b01dc0cca541c619b2be
Which actually replaces silly calls like readx_poll_timeout(ioread32, ... .
Do you want me to (re-?)post this as a series? I can put your thunderbolt (and your changes here) and post as one big series (or you can do the same obviously).
Olliver
| |