Messages in this thread | | | Date | Thu, 30 Mar 2023 14:09:20 -0600 | Subject | Re: [PATCH][next] wifi: rndis_wlan: Replace fake flex-array with flexible-array member | From | "Gustavo A. R. Silva" <> |
| |
Hi all,
Friendly ping: who can take this, please? 😄
Thanks -- Gustavo
On 3/22/23 12:26, Gustavo A. R. Silva wrote: > Zero-length arrays as fake flexible arrays are deprecated and we are > moving towards adopting C99 flexible-array members instead. > > Address the following warning found with GCC-13 and > -fstrict-flex-array=3 enabled: > drivers/net/wireless/rndis_wlan.c:2902:23: warning: array subscript 0 is outside array bounds of ‘struct ndis_80211_auth_request[0]’ [-Warray-bounds=] > > This helps with the ongoing efforts to tighten the FORTIFY_SOURCE > routines on memcpy() and help us make progress towards globally > enabling -fstrict-flex-arrays=3 [1]. > > Link: https://github.com/KSPP/linux/issues/21 > Link: https://github.com/KSPP/linux/issues/274 > Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1] > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/net/wireless/legacy/rndis_wlan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/legacy/rndis_wlan.c b/drivers/net/wireless/legacy/rndis_wlan.c > index bf72e5fd39cf..54c347fa54c4 100644 > --- a/drivers/net/wireless/legacy/rndis_wlan.c > +++ b/drivers/net/wireless/legacy/rndis_wlan.c > @@ -209,7 +209,7 @@ struct ndis_80211_status_indication { > union { > __le32 media_stream_mode; > __le32 radio_status; > - struct ndis_80211_auth_request auth_request[0]; > + DECLARE_FLEX_ARRAY(struct ndis_80211_auth_request, auth_request); > struct ndis_80211_pmkid_cand_list cand_list; > } u; > } __packed;
| |