Messages in this thread | | | From | Anjali Kulkarni <> | Subject | Re: [PATCH v3 6/7] netlink: Add multicast group level permissions | Date | Fri, 31 Mar 2023 17:00:27 +0000 |
| |
> On Mar 30, 2023, at 11:39 PM, Jakub Kicinski <kuba@kernel.org> wrote: > > On Wed, 29 Mar 2023 11:25:42 -0700 Anjali Kulkarni wrote: >> A new field perm_groups is added in netlink_sock to store the protocol's >> multicast group access permissions. This is to allow for a more fine >> grained access control than just at the protocol level. These >> permissions can be supplied by the protocol via the netlink_kernel_cfg. >> A new function netlink_multicast_allowed() is added, which checks if >> the protocol's multicast group has non-root access before allowing bind. > > Is there a reason this is better than implementing .bind > in the connector family and filtering there?
Are you suggesting adding something like a new struct proto_ops for the connector family? I have not looked into that, though that would seem like a lot of work, and also I have not seen any infra structure to call into protocol specific bind from netlink bind?
| |