Messages in this thread | | | Date | Fri, 31 Mar 2023 13:05:59 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] printk: Remove obsoleted check for non-existent "user" object |
| |
On (23/03/20 00:02), Stanislav Kinsburskii wrote: > From: Stanislav Kinsburskii <stanislav.kinsburski@gmail.com> > > The original check for non-null "user" object was introduced by commit > e11fea92e13f ("kmsg: export printk records to the /dev/kmsg interface") when > "user" could be NULL if /dev/ksmg was opened for writing. > > Subsequent change 750afe7babd1 ("printk: add kernel parameter to control > writes to /dev/kmsg") made "user" context required for files opened for write, > but didn't remove now redundant checks for it to be non-NULL. > > This patch removes the dead code while preserving the current logic. > > Signed-off-by: Stanislav Kinsburskii <stanislav.kinsburski@gmail.com> > CC: Petr Mladek <pmladek@suse.com> > CC: Sergey Senozhatsky <senozhatsky@chromium.org> > CC: Steven Rostedt <rostedt@goodmis.org> > CC: John Ogness <john.ogness@linutronix.de> > CC: linux-kernel@vger.kernel.org
Looks like we should be fine Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
| |