Messages in this thread | | | Subject | Re: [PATCH v3 3/4] checkpatch: allow Closes tags with links | From | Joe Perches <> | Date | Thu, 30 Mar 2023 15:43:08 -0700 |
| |
On Thu, 2023-03-30 at 20:13 +0200, Matthieu Baerts wrote: > As a follow-up of a previous patch modifying the documentation to > allow using the "Closes:" tag, checkpatch.pl is updated accordingly. > > checkpatch.pl now no longer complain when the "Closes:" tag is used by > itself or after the "Reported-by:" tag. > > Fixes: 76f381bb77a0 ("checkpatch: warn when unknown tags are used for links") > Fixes: d7f1d71e5ef6 ("checkpatch: warn when Reported-by: is not followed by Link:")
I don't think this _fixes_ anything. I believe it's merely a new capability.
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/373 > Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net> > --- > v3: > - split into 2 patches: the previous one adds a list with all the > "link" tags. This one only allows the "Closes" tag. (Joe Perches) > - "Closes" is no longer printed between parenthesis. (Thorsten > Leemhuis) > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 9d092ff4fc16..ca58c734ff22 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -620,7 +620,7 @@ our $signature_tags = qr{(?xi: > Cc: > )}; > > -our @link_tags = qw(Link); > +our @link_tags = qw(Link Closes); > > #Create a search and print patterns for all these strings to be used directly below > our $link_tags_search = ""; >
| |