Messages in this thread | | | Date | Thu, 30 Mar 2023 19:14:41 +0200 | Subject | Re: [PATCH v6 2/2] arm64: dts: mediatek: enable i2c0 for mt8365-evk board | From | Matthias Brugger <> |
| |
On 28/03/2023 12:04, AngeloGioacchino Del Regno wrote: > Il 28/03/23 11:04, Alexandre Mergnat ha scritto: >> Enable the I2C0 bus provides communication with: >> - The integrated RT9466 Switching Battery Charger. >> - The integrated MT6691 LP4X buck for VDDQ. >> - The integrated MT6691 LP4X buck for VDD2. >> - The pin header, to plug external I2C devices. >> >> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> >> --- >> arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts >> b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts >> index 4683704ea235..adc79ba14b33 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts >> +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts >> @@ -87,6 +87,13 @@ optee_reserved: optee@43200000 { >> }; >> }; >> +&i2c0 { >> + clock-frequency = <100000>; >> + pinctrl-0 = <&i2c0_pins>; >> + pinctrl-names = "default"; >> + status = "okay"; >> +}; >> + >> &pio { >> gpio_keys: gpio-keys-pins { >> pins { >> @@ -96,6 +103,14 @@ pins { >> }; >> }; >> + i2c0_pins: i2c0-pins { >> + pins { >> + bias-pull-up; > > I prefer seeing pinmux first, any other properties last.... > If Matthias can please fix that while applying... >
Done and queued the whole series.
Thanks! Matthias
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > >
| |