Messages in this thread | | | Date | Fri, 3 Mar 2023 10:53:05 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 21/27] mfd: bcm2835-pm: remove MODULE_LICENSE in non-modules |
| |
On Fri, 24 Feb 2023, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Lee Jones <lee@kernel.org> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: Ray Jui <rjui@broadcom.com> > Cc: Scott Branden <sbranden@broadcom.com> > Cc: linux-rpi-kernel@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/mfd/bcm2835-pm.c | 1 - > 1 file changed, 1 deletion(-)
Applied, thanks
-- Lee Jones [李琼斯]
| |