Messages in this thread | | | Date | Wed, 29 Mar 2023 20:42:00 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v2] iommu/rockchip: Add missing set_platform_dma_ops callback |
| |
On Fri, Mar 24, 2023 at 11:11:27AM +0000, Steven Price wrote: > Similar to exynos, we need a set_platform_dma_ops() callback for proper > operation on ARM 32 bit after recent changes in the IOMMU framework > (detach ops removal). But also the use of a NULL domain is confusing. > > Rework the code to have a singleton rk_identity_domain which is assigned > to domain when using an identity mapping rather than "detaching". This > makes the code easier to reason about. > > Signed-off-by: Steven Price <steven.price@arm.com> > --- > Changes since v1[1]: > > * Reworked the code to avoid a NULL domain, instead a singleton > rk_identity_domain is used instead. The 'detach' language is no > longer used. > > [1] https://lore.kernel.org/r/20230315164152.333251-1-steven.price%40arm.com > > drivers/iommu/rockchip-iommu.c | 50 ++++++++++++++++++++++++++-------- > 1 file changed, 39 insertions(+), 11 deletions(-)
Aside from the pm stuff this looks OK to me
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Thanks, Jason
| |