lkml.org 
[lkml]   [2023]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] iommu/rockchip: Add missing set_platform_dma_ops callback
On Fri, Mar 24, 2023 at 11:11:27AM +0000, Steven Price wrote:
> Similar to exynos, we need a set_platform_dma_ops() callback for proper
> operation on ARM 32 bit after recent changes in the IOMMU framework
> (detach ops removal). But also the use of a NULL domain is confusing.
>
> Rework the code to have a singleton rk_identity_domain which is assigned
> to domain when using an identity mapping rather than "detaching". This
> makes the code easier to reason about.
>
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> Changes since v1[1]:
>
> * Reworked the code to avoid a NULL domain, instead a singleton
> rk_identity_domain is used instead. The 'detach' language is no
> longer used.
>
> [1] https://lore.kernel.org/r/20230315164152.333251-1-steven.price%40arm.com
>
> drivers/iommu/rockchip-iommu.c | 50 ++++++++++++++++++++++++++--------
> 1 file changed, 39 insertions(+), 11 deletions(-)

Aside from the pm stuff this looks OK to me

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Thanks,
Jason

\
 
 \ /
  Last update: 2023-03-30 01:42    [W:0.102 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site