Messages in this thread | | | Date | Tue, 28 Mar 2023 14:49:58 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v2 6/8] net: phy: at803x: Make SmartEEE support optional and configurable via ethtool |
| |
> > @@ -302,6 +312,8 @@ struct at803x_priv { > > u8 smarteee_lpi_tw_100m; > > bool is_fiber; > > bool is_1000basex; > > + bool tx_lpi_on; > > @Andrew, this variable can be replace by your phydev->tx_lpi_enabled > variable. Should I wait for your patches went mainline?
I was wondering about the overlap and the best way to address it.
My patchset is also a bit big, and getting bigger. So it might make sense to split out some of the bits you need and get them merged first.
You need the MAC indicating it is EEE capable. I don't store that information explicitly, but that is a quick simple change. You also need phydev->tx_lpi_enabled. Anything else?
Andrew
| |