Messages in this thread | | | Date | Tue, 28 Mar 2023 19:50:40 +0900 | Subject | Re: [PATCH] soc: apple: rtkit: Fix buffer address field width | From | Hector Martin <> |
| |
On 24/02/2023 15.49, Asahi Lina wrote: > The buffer address field is missing two bits. This matters for the GPU, > which uses upper-half 64-bit addresses on the ASC and those get sign > extended from the mailbox message field, so the right number of high > bits need to be set. > > Signed-off-by: Asahi Lina <lina@asahilina.net> > --- > drivers/soc/apple/rtkit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c > index 35ec35aa500d..a02a44a745f6 100644 > --- a/drivers/soc/apple/rtkit.c > +++ b/drivers/soc/apple/rtkit.c > @@ -55,7 +55,7 @@ enum { > > #define APPLE_RTKIT_BUFFER_REQUEST 1 > #define APPLE_RTKIT_BUFFER_REQUEST_SIZE GENMASK_ULL(51, 44) > -#define APPLE_RTKIT_BUFFER_REQUEST_IOVA GENMASK_ULL(41, 0) > +#define APPLE_RTKIT_BUFFER_REQUEST_IOVA GENMASK_ULL(43, 0) > > #define APPLE_RTKIT_SYSLOG_TYPE GENMASK_ULL(59, 52) > > > --- > base-commit: 83f978b63fa7ad474ca22d7e2772c5988101c9bd > change-id: 20230224-gpu-up-rtkit-f4bc18e78c8a > > Thank you, > ~~ Lina >
Applied to asahi-soc/soc!
- Hector
| |