Messages in this thread | | | Date | Tue, 28 Mar 2023 10:57:25 +0300 | From | Mathias Nyman <> | Subject | Re: [PATCH] xhci: Free the command allocated for setting LPM if we return early |
| |
On 28.3.2023 1.25, Mirsad Goran Todorovac wrote: > On 27. 03. 2023. 11:50, Mathias Nyman wrote: >> The command allocated to set exit latency LPM values need to be freed in >> case the command is never queued. This would be the case if there is no >> change in exit latency values, or device is missing. >> >> Fixes: 5c2a380a5aa8 ("xhci: Allocate separate command structures for each LPM command") >> Cc: <Stable@vger.kernel.org> >> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> >> --- >> drivers/usb/host/xhci.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c >> index bdb6dd819a3b..6307bae9cddf 100644 >> --- a/drivers/usb/host/xhci.c >> +++ b/drivers/usb/host/xhci.c >> @@ -4442,6 +4442,7 @@ static int __maybe_unused xhci_change_max_exit_latency(struct xhci_hcd *xhci, >> >> if (!virt_dev || max_exit_latency == virt_dev->current_mel) { >> spin_unlock_irqrestore(&xhci->lock, flags); >> + xhci_free_command(xhci, command); >> return 0; >> } >> > > After more testing, I can confirm that your patch fixes the leak in the original > environment.
Thanks for testing. Can I add the tags below to the patch?
Reported-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr> Tested-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Thanks Mathias
| |