Messages in this thread | | | Date | Tue, 28 Mar 2023 09:23:04 +0200 | Subject | Re: [Patch v4 01/10] dt-bindings: memory: tegra: add bpmp ref in tegra234-mc node | From | Krzysztof Kozlowski <> |
| |
On 27/03/2023 18:14, Sumit Gupta wrote: > For Tegra234, add the "nvidia,bpmp" property within the Memory > Controller (MC) node to reference BPMP node. This is needed in > the MC driver to pass the client info to the BPMP-FW when memory > interconnect support is available. > > Signed-off-by: Sumit Gupta <sumitg@nvidia.com> > --- > .../bindings/memory-controllers/nvidia,tegra186-mc.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml > index 935d63d181d9..398d27bb2373 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml > @@ -58,6 +58,10 @@ properties: > "#interconnect-cells": > const: 1 > > + nvidia,bpmp: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle of the node representing the BPMP
Why do you need this multiple times? Both in parent and all external-mc children?
> + > patternProperties: > "^external-memory-controller@[0-9a-f]+$": > description: > @@ -220,6 +224,9 @@ allOf: > - const: ch14 > - const: ch15 > > + nvidia,bpmp: > + description: phandle of the node representing the BPMP
I don't understand for what this hunk is. It does not look like in correct place at all.
Best regards, Krzysztof
| |