Messages in this thread | | | From | Alexandre Mergnat <> | Date | Mon, 27 Mar 2023 12:56:36 +0200 | Subject | Re: [PATCH v5 2/2] arm64: dts: mediatek: enable i2c0 for mt8365-evk board |
| |
Hi Angelo,
Le lun. 27 mars 2023 à 10:45, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> a écrit : > > Il 27/03/23 10:27, Alexandre Mergnat ha scritto: > > Enable the I2C0 bus provides communication with: > > - The integrated RT9466 Switching Battery Charger. > > - The integrated MT6691 LP4X buck for VDDQ. > > - The integrated MT6691 LP4X buck for VDD2. > > - The pin header, to plug external I2C devices. > > > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > > --- > > arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > > index 4683704ea235..35cb142004a4 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > > +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > > @@ -87,6 +87,13 @@ optee_reserved: optee@43200000 { > > }; > > }; > > > > +&i2c0 { > > + clock-frequency = <100000>; > > + pinctrl-0 = <&i2c0_pins>; > > + pinctrl-names = "default"; > > + status = "okay"; > > +}; > > + > > &pio { > > gpio_keys: gpio-keys-pins { > > pins { > > @@ -96,6 +103,15 @@ pins { > > }; > > }; > > > > + i2c0_pins: i2c0-pins { > > + pins { > pinmux = ...pins... > bias-pull-up = <your-pull-up-adv-value>; > }; > > ...and please do *not* use the mediatek,pull-up-adv property: this is > supposed to be there only for older devicetrees and there's a replacement > for it.... unless you have any specific reason to do so (and if you do, > you should well explain that).
bias-pull-up isn't necessary currently because MT8365 doesn't use MTK paris/moore drivers.
> Besides, if you introduce the usage of that property in any 8365 devicetree, > the previously proposed 8365 pinctrl cleanup will become a bit harder to do.
I'm thinking of deprecating the "mediatek,pull-up-adv", "mediatek,pull-down-adv" properties from mt8365 pinctrl binding too.
Regards, Alex
| |