Messages in this thread | | | Date | Mon, 27 Mar 2023 16:21:19 +0530 | From | Kautuk Consul <> | Subject | Re: [PATCH v4] arch/powerpc/kvm: kvmppc_hv_entry: remove .global scope |
| |
On 2023-03-27 20:30:02, Nicholas Piggin wrote: > On Mon Mar 27, 2023 at 8:04 PM AEST, Kautuk Consul wrote: > > kvmppc_hv_entry isn't called from anywhere other than > > book3s_hv_rmhandlers.S itself. Removing .global scope for > > this function and annotating it with SYM_CODE_START_LOCAL > > and SYM_CODE_END. > > Does removing .global introduce the objtool warning, or was it already > present? Just trying to understand if this is two changes or one (not > that it really matters, maybe just for the purpose of the changelog). Yes. Just removing .global introduces the objtool warning. > > Since the patch only touches KVM, subject should follow arch/powerpc/kvm > convention, which is not the same as the rest of arch/powerpc. KVM: PPC: > Book3S HV: Okay. Do you need me to send another patch in "KVM: PPC: Book3S HV:" format ? > > Otherwise seems okay > > Reviewed-by: Nicholas Piggin <npiggin@gmail.com> Thank you! > > Thanks, > Nick > > > > > Signed-off-by: Kautuk Consul <kconsul@linux.vnet.ibm.com> > > --- > > arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > > index acf80915f406..0a9781192b86 100644 > > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S > > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S > > @@ -502,8 +502,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_ARCH_207S) > > * * > > *****************************************************************************/ > > > > -.global kvmppc_hv_entry > > -kvmppc_hv_entry: > > +SYM_CODE_START_LOCAL(kvmppc_hv_entry) > > > > /* Required state: > > * > > @@ -940,6 +939,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_HAS_PPR) > > ld r4, VCPU_GPR(R4)(r4) > > HRFI_TO_GUEST > > b . > > +SYM_CODE_END(kvmppc_hv_entry) > > > > secondary_too_late: > > li r12, 0 > > -- > > 2.39.2 >
| |