lkml.org 
[lkml]   [2023]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xfs: fix BUG_ON in xfs_getbmap()
On Mon, Mar 27, 2023 at 06:47:54PM -0700, Christoph Hellwig wrote:
> On Mon, Mar 27, 2023 at 06:43:28PM -0700, Darrick J. Wong wrote:
> > <shrug> Seeing as the data fork mappings can change the instant the
> > ILOCK drops, I'm not /that/ worried about users seeing a delalloc
> > mapping even if the user requested a flush. The results are already
> > obsolete when they get to userspace, unless the application software has
> > found another means to lock out access to the file.
>
> That is true, but then again the users asked to not see delalloc
> mappings, so we really shouldn't report one, right?

Yeah, I suppose so. I wonder how many programs there are out there that
don't pass in BMV_IF_DELALLOC /and/ can't handle that? But I suppose
taking MMAP_EXCL is good enough to shut up the obvious assertion vector.

The COW implementation probably ought to be doing the flush too.

--D

\
 
 \ /
  Last update: 2023-03-28 04:04    [W:1.347 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site